----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116662/#review52409 -----------------------------------------------------------
Good work! The code looks very good. I have just marked a few trivial issues. There are two things I'd like to do before giving the ship it: 1. test it on a real document 2. Check if there are left-overs from the code that you copied that could be removed. And one thing: I noticed that you removed the other people's copyright notice. That's not really nice when you first copy somebody else's work. I think you should put them back (and keep yours too of course). words/part/CMakeLists.txt <https://git.reviewboard.kde.org/r/116662/#comment37083> Even though it's a triviality, normally empty spaces like this are frowned upon in calligra... (I've been bitten by this many times myself.) words/part/dockers/KWNavigationDocker.h <https://git.reviewboard.kde.org/r/116662/#comment37084> Same as above with all the spaces. Check out the devtools/fixsrc. There is an option to remove training spaces if I remember correctly. - Inge Wallin On March 8, 2014, 6:18 p.m., Denis Kuplyakov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116662/ > ----------------------------------------------------------- > > (Updated March 8, 2014, 6:18 p.m.) > > > Review request for Calligra, Inge Wallin and Dan Leinir Turthra Jensen. > > > Repository: calligra > > > Description > ------- > > That's the navigator docker for Words. It allow to quickly navigate through > document by jumping to sections headers. > Navigator looks through all paragraphs with outline property, and stores them > in QTreeView allowing fast jump with single click. > > I want some response about UI: > 1) maybe make the rows bigger? > > and about the implementation: > 2) how can we track structure changes more effective to avoid complete > rebuilding of tree? > 3) view is flickering when updating.. > > > Diffs > ----- > > words/part/dockers/KWNavigationWidget.cpp PRE-CREATION > words/part/dockers/KWNavigationWidget.h PRE-CREATION > words/part/dockers/KWNavigationDocker.cpp PRE-CREATION > words/part/KWFactory.cpp 14dfbed > words/part/dockers/KWNavigationDocker.h PRE-CREATION > words/part/CMakeLists.txt e6e39e8 > > Diff: https://git.reviewboard.kde.org/r/116662/diff/ > > > Testing > ------- > > Have tested it on document, containing 3 pages with many headers of different > levels. > > > Thanks, > > Denis Kuplyakov > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
