----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122584/#review76108 -----------------------------------------------------------
Wouldn't a much better solution be to make the Private class of the KoMarker shared? If so, we could have the collection store KoMarkers instead of a collection of KoMarker*s. Making KoMarker itself a QSharedData feels very strange and is different than anything else in Calligra. - Inge Wallin On Feb. 16, 2015, 2:26 a.m., Sven Langkamp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122584/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2015, 2:26 a.m.) > > > Review request for Calligra. > > > Bugs: 343719 > http://bugs.kde.org/show_bug.cgi?id=343719 > > > Repository: calligra > > > Description > ------- > > Use shared pointers for markers. > Currently markers crash Krita on close (bug 343719). The problem is that > existing path shapes point to the marker even after it's deleted. The patch > solves that by using shared pointers for the marker. > > > Diffs > ----- > > libs/flake/KoMarkerData.cpp 247e151 > libs/flake/KoMarker.h fa2adfd > libs/flake/KoMarkerCollection.h 1555363 > libs/flake/KoMarkerCollection.cpp 98e80f8 > > Diff: https://git.reviewboard.kde.org/r/122584/diff/ > > > Testing > ------- > > Tested with Krita. > > > Thanks, > > Sven Langkamp > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
