Re: Top 15 Mailinglists with messages in moderation

2019-10-27 Thread Elvis Stansvik
Den tors 1 aug. 2019 kl 13:47 skrev Boudewijn Rempt : > > Is there still somebody here who can take care of the calligra-devel mailing > list? I can't promise to check the filter daily, but I've put it in my calendar to look it over every Friday now (already have the login). I promised back in 2

Re: GPL Linking exception or transformation to LGPL?

2015-06-15 Thread Elvis Stansvik
2015-06-15 12:55 GMT+02:00 Christophe Conil : > Hi Jos, Jaroslaw and Alexander, > > First, thank you very much for the fast and kind answers! > I didn't knew about the possibility of the GPL to use the code in my > own executable, thanks for spotting that! I guess this solves my > question: I'm in

Re: Problem using Vc with CMake 3.0 and kf5

2015-05-25 Thread Elvis Stansvik
let some expert comment on that. It feels we're getting closer at least. Elvis > > > On Mon, 25 May 2015, Elvis Stansvik wrote: > > 2015-05-25 16:13 GMT+02:00 Boudewijn Rempt : >> Weird, it worked for me: >> >> https://paste.kde.org/pmvww

Re: Problem using Vc with CMake 3.0 and kf5

2015-05-25 Thread Elvis Stansvik
2015-05-25 16:13 GMT+02:00 Boudewijn Rempt : > Weird, it worked for me: > > https://paste.kde.org/pmvwwhyqp -- in fact, the header file isn't used or > needed in the example at all. I seem to be getting the same result as Alex (I think): https://paste.kde.org/pke2ztbok I'm a little pussled by y

Re: Pl unsubscribe

2015-05-24 Thread Elvis Stansvik
Sure thing. Sign me up :) Elvis > > > On Sun, 24 May 2015, Elvis Stansvik wrote: > > 2015-05-24 8:25 GMT+02:00 Ruc : >> Pl. stop sending me mails about KDE Dev forum, >> >> >> You can unsubscribe from the list at >> https://ma

Re: Pl unsubscribe

2015-05-24 Thread Elvis Stansvik
2015-05-24 8:25 GMT+02:00 Ruc : > Pl. stop sending me mails about KDE Dev forum, > You can unsubscribe from the list at https://mail.kde.org/mailman/listinfo/calligra-devel Cheers, Elvis > > Thanks > Ruchin p shah > Sent from my iPad > ___ > calligra

Re: Please stop sending me e-mails

2015-05-23 Thread Elvis Stansvik
2015-05-23 18:54 GMT+02:00 John Culleton : > On Sat, 23 May 2015 10:04:53 +0200 > Elvis Stansvik wrote: > > > Hi Julia, > > > > You can unsubscribe by entering your e-mail > > address at this page: > > > >https://mail.kde.org/mailman/listinfo/cal

Re: Please stop sending me e-mails

2015-05-23 Thread Elvis Stansvik
Hi Julia, You can unsubscribe by entering your e-mail address at this page: https://mail.kde.org/mailman/listinfo/calligra-devel And then hit "Unsubscribe or edit options". Cheers, Elvis 2015-05-23 9:58 GMT+02:00 Julia AGZIOU : > Hi ! > > I'm so worry about receiving loads of yout e-mails

Re: Proposal: standardized (subdir) names for 3rdparty/generated code

2015-03-06 Thread Elvis Stansvik
2015-03-06 20:05 GMT+01:00 Friedrich W. H. Kossebau : > Am Freitag, 6. März 2015, 08:07:07 schrieb Elvis Stansvik: > > 2015-03-06 1:16 GMT+01:00 Friedrich W. H. Kossebau : > > > Hi, > > > > > > so I spent quite some time scanning the sources, below is what I f

Re: Re: Preview of astyle-kdelibs changes up in a branch (was: Re: [Port blocker] Re: [Kexi-devel] RFC: plan for starting the Qt5/KF5 port)

2015-03-06 Thread Elvis Stansvik
2015-03-06 8:25 GMT+01:00 Dmitry Kazakov : > Hi! > > I looked through the patch and updated the google docs: > > https://docs.google.com/document/d/1jhq6oXuXKvTilJhcoS6FVKO7yYRu2yCgBS9ojhc2QRU/edit# > > The changes which I believe we must fix before applying it to master: > > 1) Inlined functions.

Re: Proposal: standardized (subdir) names for 3rdparty/generated code

2015-03-05 Thread Elvis Stansvik
2015-03-06 1:16 GMT+01:00 Friedrich W. H. Kossebau : > Hi, > > so I spent quite some time scanning the sources, below is what I found as > TODO. > > So the idea still is: put 3rd-party code into a subdir "3rdparty" and put > generated and committed code into a subdir "generated", either locally or

Re: Getting to 100 % succedding tests (for 2.9), or, simply dropping them all?

2015-02-06 Thread Elvis Stansvik
2015-02-06 14:34 GMT+01:00 Friedrich W. H. Kossebau : > Am Freitag, 6. Februar 2015, 08:08:53 schrieb Elvis Stansvik: > > But, re. running certain only certain sets of test, perhaps we could > label > > tests using > > > >set_tests_properties(SomeTest SomeOtherTe

Re: Getting to 100 % succedding tests (for 2.9), or, simply dropping them all?

2015-02-05 Thread Elvis Stansvik
2015-02-05 23:00 GMT+01:00 Friedrich W. H. Kossebau : > Am Donnerstag, 5. Februar 2015, 12:47:22 schrieb Dmitry Kazakov: > > > > There is one important point: *all* the test sets should be compiled > > > > when > > > > KDE_BUILD_TESTS==on > > > > > > Where compiled!=run? Makes sense, I agree. The

Re: Review Request 122278: Additional changes in section handling

2015-01-28 Thread Elvis Stansvik
> On jan 27, 2015, 7:34 e.m., Camilla Boemann wrote: > > libs/kotext/KoSectionManager.cpp, line 120 > > > > > > why no long const ? > > Denis Kuplyakov wrote: > I don't know why, but QHash::find() isn't cons

Re: Review Request 122254: Remove inline objects from manager in DeleteCommand

2015-01-25 Thread Elvis Stansvik
ed from the bottom of the page/document. Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 122254: Remove inline objects from manager in DeleteCommand

2015-01-25 Thread Elvis Stansvik
bunch of references with the mouse and hitting backspace/delete. Both footnotes and endnotes were removed from the bottom of the page/document. Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 122254: Remove inline objects from manager in DeleteCommand

2015-01-25 Thread Elvis Stansvik
ious places, and removing them by backspacing/deleting across their references, or selecting a bunch of references with the mouse and hitting backspace/delete. Both footnotes and endnotes were removed from the bottom of the page/document. Thanks, Elvis Stansvik ___

Re: Review Request 120733: Pass more data between layout and RootAreaProvider

2014-11-27 Thread Elvis Stansvik
> On nov 27, 2014, 9:14 e.m., Camilla Boemann wrote: > > libs/textlayout/KoTextDocumentLayout.cpp, line 858 > > > > > > but doing nothing and not incrmenting ?? either this objection is too complex for me to u

Re: Review Request 119502: Use unset(..) instead of set(..) to unset CMake variables

2014-08-04 Thread Elvis Stansvik
tMacros.cmake 8b0492b Diff: https://git.reviewboard.kde.org/r/119502/diff/ Testing --- Did a default CMake run. Everything seemed fine, the semantics should not have changed. Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org ht

Re: Moving Calligra / Kexi TODOs migrate into todo.kde.org

2014-07-29 Thread Elvis Stansvik
2014-07-29 13:39 GMT+02:00 Jaroslaw Staniek : > On 29 July 2014 13:09, Ben Cooksley wrote: > > On 29 July 2014 23:06, Jaroslaw Staniek wrote: > >> On 29 July 2014 12:09, Ben Cooksley wrote: > >>> On 29 July 2014 22:00, Jaroslaw Staniek wrote: > On 29 July 2014 11:54, Ben Cooksley wrote:

Re: Review Request 119502: Use unset(..) instead of set(..) to unset CMake variables

2014-07-27 Thread Elvis Stansvik
eLists.txt ae4d140 cmake/modules/CalligraProductSetMacros.cmake 8b0492b Diff: https://git.reviewboard.kde.org/r/119502/diff/ Testing --- Did a default CMake run. Everything seemed fine, the semantics should not have changed. Thanks, Elvis Stansvik ___ c

Re: Review Request 119496: Log explicitely why a product was dropped

2014-07-27 Thread Elvis Stansvik
> On July 27, 2014, 4:10 p.m., Elvis Stansvik wrote: > > cmake/modules/CalligraProductSetMacros.cmake, line 37 > > <https://git.reviewboard.kde.org/r/119496/diff/1/?file=293440#file293440line37> > > > > is this necessary? it just unsets ${_current_flag} righ

Review Request 119502: Use unset(..) instead of set(..) to unset CMake variables

2014-07-27 Thread Elvis Stansvik
should not have changed. Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 119496: Log explicitely why a product was dropped

2014-07-27 Thread Elvis Stansvik
t's a little clearer i think. at least i had to consult the cmake docs to realize set(..) actually unsets when no value is passed in :) - Elvis Stansvik On July 27, 2014, 3:55 p.m., Friedrich W. H. Kossebau wrote: > > --- >

Re: Style objects for applications and filters

2014-05-04 Thread Elvis Stansvik
2014-05-04 7:13 GMT+02:00 Inge Wallin : > On Sunday, May 04, 2014 06:18:45 Thorsten Zachmann wrote: > > > On Monday, April 28, 2014 10:31:45 PM Inge Wallin wrote: > > > > * Represent styles as text attributes wherever possible so that they > can > > > > be > > > > > > > > complete, i.e. not throw

Re: Review Request 114610: Remove unused directory karbon/plugins/dockers

2013-12-22 Thread Elvis Stansvik
9aba662 karbon/plugins/dockers/karbondockersplugin.desktop dba38be Diff: https://git.reviewboard.kde.org/r/114610/diff/ Testing --- Built and launched Karbon. Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https

Re: Review Request 114613: Add support for Karbon specific dockers

2013-12-22 Thread Elvis Stansvik
-- karbon/ui/KarbonFactory.cpp 1e3bf31 karbon/data/CMakeLists.txt 57d0056 karbon/data/karbon_dock.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/114613/diff/ Testing --- Tested locally that Karbon will now load plugins of type "Karbon/Dock".

Review Request 114613: Add support for Karbon specific dockers

2013-12-22 Thread Elvis Stansvik
ock.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/114613/diff/ Testing --- Tested locally that Karbon will now load plugins of type "Karbon/Dock". Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde

Review Request 114610: Remove unused directory karbon/plugins/dockers

2013-12-22 Thread Elvis Stansvik
://git.reviewboard.kde.org/r/114610/diff/ Testing --- Built and launched Karbon. Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 114578: Fix crash in SnapGuideDocker

2013-12-21 Thread Elvis Stansvik
Testing --- Launched Karbon, created a new document. Without the patch, Karbon crashes on exit. With it, all is fine. Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 114578: Fix crash in SnapGuideDocker

2013-12-20 Thread Elvis Stansvik
it, all is fine. Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 114435: Turn off anti-aliasing when painting Karbon page rect / margins

2013-12-16 Thread Elvis Stansvik
81a13-2d70-4242-bf7d-f10b7bce011a__before.png After (without anti-aliasing) http://git.reviewboard.kde.org/media/uploaded/files/2013/12/13/c2057f12-6ee0-4239-8075-6536373a3f30__after.png Thanks, Elvis Stansvik ___ calligra-devel mailing list call

Re: Review Request 114434: Consistent style for tool tooltips

2013-12-16 Thread Elvis Stansvik
actory.cpp a13d8ad Diff: http://git.reviewboard.kde.org/r/114434/diff/ Testing --- Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 114435: Turn off anti-aliasing when painting Karbon page rect / margins

2013-12-16 Thread Elvis Stansvik
to false. Ok to push? - Elvis --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114435/#review45653 --- On Dec. 13, 2013

Re: Review Request 114434: Consistent style for tool tooltips

2013-12-16 Thread Elvis Stansvik
pp 2d70f06 stage/part/tools/KPrPlaceholderToolFactory.cpp a13d8ad Diff: http://git.reviewboard.kde.org/r/114434/diff/ Testing --- Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinf

Re: Review Request 114435: Turn off anti-aliasing when painting Karbon page rect / margins

2013-12-13 Thread Elvis Stansvik
3/1e481a13-2d70-4242-bf7d-f10b7bce011a__before.png After (without anti-aliasing) http://git.reviewboard.kde.org/media/uploaded/files/2013/12/13/c2057f12-6ee0-4239-8075-6536373a3f30__after.png Thanks, Elvis Stansvik ___ calligra-devel mailing lis

Re: Review Request 114434: Consistent style for tool tooltips

2013-12-13 Thread Elvis Stansvik
r/114434/diff/1/?file=224669#file224669line34> > > > > maybe "Draw path" Alright, will change. - Elvis --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org

Review Request 114435: Turn off anti-aliasing when painting Karbon page rect / margins

2013-12-13 Thread Elvis Stansvik
rd.kde.org/media/uploaded/files/2013/12/13/c2057f12-6ee0-4239-8075-6536373a3f30__after.png Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 114434: Consistent style for tool tooltips

2013-12-13 Thread Elvis Stansvik
pp 3686bf7 plugins/videoshape/VideoToolFactory.cpp 8c75f61 sheets/plugins/calendar/CalendarToolFactory.cpp 77e4f19 sheets/shape/TableToolFactory.cpp 2d70f06 stage/part/tools/KPrPlaceholderToolFactory.cpp a13d8ad Diff: http://git.reviewboard.kde.org/r/114434/diff/ Testing --- Than

Re: (Very) basic script for pre-review style checking

2013-11-01 Thread Elvis Stansvik
> > [1] > That was supposed to be [1] https://github.com/matiasb/python-unidiff Elvis ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

(Very) basic script for pre-review style checking

2013-11-01 Thread Elvis Stansvik
Here it goes: #!/usr/bin/env python import re import fileinput import unidiff # Add new checks as (, ) tuples. checks = { (re.compile(r'.* \).*'), "Excessive space before ')'"), (re.compile(r'.*[A-Za-z_][A-Za-z0-9_]*\s*\( .*'), "Excessive space after '('"), (re.compil

Re: suffix and prefix in and

2013-08-05 Thread Elvis Stansvik
2013/8/5 Sebastian Sauer > On 08/05/2013 07:25 PM, Elvis Stansvik wrote: > >> 2013/8/5 Elvis Stansvik >> >> 2013/8/5 Jos van den Oever >>> >>> Look what I found in libs/odf/KoOdfNumberStyles.cpp: >>>> >>>> >>>

Re: suffix and prefix in and

2013-08-05 Thread Elvis Stansvik
2013/8/5 Elvis Stansvik > 2013/8/5 Jos van den Oever > >> Look what I found in libs/odf/KoOdfNumberStyles.**cpp: >> >> === >> //This is an extension of numeric style. For the moment we used namespace >> of >> //oasis format for specific calligra ex

Re: suffix and prefix in and

2013-08-05 Thread Elvis Stansvik
2013/8/5 Elvis Stansvik > 2013/8/5 Jos van den Oever > >> Look what I found in libs/odf/KoOdfNumberStyles.**cpp: >> >> === >> //This is an extension of numeric style. For the moment we used namespace >> of >> //oasis format for specific calligra ex

Re: suffix and prefix in and

2013-08-05 Thread Elvis Stansvik
2013/8/5 Jos van den Oever > Look what I found in libs/odf/KoOdfNumberStyles.**cpp: > > === > //This is an extension of numeric style. For the moment we used namespace > of > //oasis format for specific calligra extension. Change it for the future. > void addCalligraNumericStyleExtensi**on(KoXmlW

Re: Review Request 110700: Remove unused storage/API from StyleManager

2013-08-04 Thread Elvis Stansvik
Testing --- Tested bibliography functionality before/after the removal. There was no change in behavior that I could see. Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 111787: Page Layout improvements for Words

2013-08-04 Thread Elvis Stansvik
> On Aug. 4, 2013, 11:21 a.m., Inge Wallin wrote: > > words/part/pagetool/KWPageTool.cpp, line 272 > > > > > > is "style" the name of the style? If so, I think it would be clearer > > if the parameter was called

Re: Review Request 111326: Install all calligralibs headers in ${INCLUDE_INSTALL_DIR}/calligra

2013-06-30 Thread Elvis Stansvik
IMO, as 3rd parties should be able to rely on the headers being at a fixed location. For the second question; I think it makes sense to put everything under calligra/, but I'll let more people chime in on that. - Elvis Stansvik On June 30, 2013, 9:38 p.m., Friedrich W. H. Kossebau

Re: Plan, Karbon: Disable the "Maintainer wanted" splashscreen for release branches?

2013-06-17 Thread Elvis Stansvik
2013/6/18 Friedrich W. H. Kossebau > Hi, > > I wonder if it is a go idea to have the "Maintainer wanted" splashscreen in > Plan and Karbon also enabled in the 2.7 releases. People who still see some > use in either programs surely will get annoyed quickly, and there is no > option > to turn it of

Re: Review Request 110928: Always save the position of a shape

2013-06-12 Thread Elvis Stansvik
me to the place in > the spec where it says that 0,0 is the default value? If not, there's your > answer. > > Elvis Stansvik wrote: > In 19.573.5 the spec refers to 5.2.1 of the SVG spec which says 0,0 is > the default [1]. Not 100% sure this is what we're talking

Re: Review Request 110928: Always save the position of a shape

2013-06-10 Thread Elvis Stansvik
> On June 10, 2013, 5:52 p.m., C. Boemann wrote: > > I still don't see the relation to the bug nor do I understand why we need > > to save 0,0 > > Inge Wallin wrote: > Ah, now I understand why everybody focusses on the bug. I was unclear in > my description. "This bug" in the description

Re: Calligra 2.7 release blockers

2013-06-09 Thread Elvis Stansvik
2013/6/9 Cyrille Berger Skott > On Sunday 09 Jun 2013, Boudewijn Rempt wrote: > > On Thursday 30 May 2013 May 14:57:04 Cyrille Berger wrote: > > > Hi, > > > > > > Don't forget to mark the bugs that are release blocker as such in > > > bugs.kde.org, currently there are four release blockers: > > >

Re: Anatomy of the style manager

2013-05-31 Thread Elvis Stansvik
second step should probably be to improve them. > Also there are some really good wish items for the style manager which > ought to be implemented. > Perhaps I'll have some time over this summer despite my job, but no guarantees PierreSt, who is actually still alive > Good news

Re: Review Request 110624: Epub generation improvement (new metadata)

2013-05-30 Thread Elvis Stansvik
ttp://git.reviewboard.kde.org/r/110624/#comment24739> could put a break; after this line. - Elvis Stansvik On May 30, 2013, 7:59 p.m., Jérémy BOURDIOL wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.r

Review Request 110723: Add tests for adding applied styles and applying added styles

2013-05-30 Thread Elvis Stansvik
/styles/tests/TestStyleManager.cpp a418472 Diff: http://git.reviewboard.kde.org/r/110723/diff/ Testing --- Passes here. Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra

Re: Review Request 110700: Remove unused storage/API from StyleManager

2013-05-30 Thread Elvis Stansvik
g built into the structure of the SM itself. - Elvis --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110700/#review33396 ----

Re: Review Request 110708: Add some basic unit tests for the style manager

2013-05-29 Thread Elvis Stansvik
sting --- The tests all pass here. Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 110708:

2013-05-29 Thread Elvis Stansvik
h PRE-CREATION libs/kotext/styles/tests/TestStyleManager.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/110708/diff/ Testing --- The tests all pass here. Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org

Re: Test failures

2013-05-29 Thread Elvis Stansvik
False alarm. Cleaned my install dir and now 100% passes. Sorry for the noise :) Elvis 2013/5/29 Elvis Stansvik > Hi folks, > > I'm seeing very different test results from Jenkins on my computer: > > 89% tests passed, 17 tests failed out of 150 > > Total Test time (

Review Request 110700: Remove unused storage/API from StyleManager

2013-05-28 Thread Elvis Stansvik
was no change in behavior that I could see. Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Anatomy of the style manager

2013-05-28 Thread Elvis Stansvik
Hi again, Some more questions about the style manager :) The style manager currently contains, among other things: QHash charStyles; QHash paragStyles; QHash unusedParagraphStyles; QVector m_usedCharacterStyles; QVector m_usedParagraphStyles; The first two are the ones that

Review Request 110696: Fix incrementing of style ID counter in StyleManager

2013-05-28 Thread Elvis Stansvik
her functions, to minimize the risk of it happening again. Diffs - libs/kotext/styles/KoStyleManager.cpp 32cbbcb Diff: http://git.reviewboard.kde.org/r/110696/diff/ Testing --- Thanks, Elvis Stansvik ___ calligra-devel mailing l

Re: Question about loading and default list/bib/ToC styles

2013-05-28 Thread Elvis Stansvik
2013/5/28 Gopalakrishna Bhat > > > > On Tue, May 28, 2013 at 8:56 AM, Thorsten Zachmann wrote: > >> On Monday 27 May 2013 21:19:56 Elvis Stansvik wrote: >> > Hi all, >> > >> > Currently trying to track down a bug and realized I'm a littl

Question about loading and default list/bib/ToC styles

2013-05-27 Thread Elvis Stansvik
Hi all, Currently trying to track down a bug and realized I'm a little unsure about something. The style manager creates a bunch of default list/bibliography/ToC styles upon construction. What should we do if, during loading, we encounter a style who's name clashes with one of these default style

Review Request 110609: Update author profile actions when configuration changes

2013-05-23 Thread Elvis Stansvik
in Words/Author/Flow and checked that the change was immediately visible in menus. Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 110593: Check for null image in drop event

2013-05-22 Thread Elvis Stansvik
before and after the fix and the crash is gone. Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 110506: Ignore application of default styles in DockerStylesComboModel

2013-05-21 Thread Elvis Stansvik
th me :) (since the entire code might change soon anyway). - Elvis Stansvik On May 19, 2013, 9:44 a.m., Elvis Stansvik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 110506: Ignore application of default styles in DockerStylesComboModel

2013-05-19 Thread Elvis Stansvik
ile Attachments The ODT provoking the crash http://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/space.odt Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 110511: Small cleanup of styles models

2013-05-18 Thread Elvis Stansvik
d bug #319048 was fixed. Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request 110506: Ignore application of default styles in DockerStylesComboModel

2013-05-18 Thread Elvis Stansvik
e.odt Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 110129: Add a loadCompleted() signal to KoMainWindow

2013-05-13 Thread Elvis Stansvik
t;. libs/main/KoMainWindow.h <http://git.reviewboard.kde.org/r/110129/#comment24100> I suggest: s/windows/window/ s/may be opened/may have been opened/ s/the window/this window/ Unless I misunderstood. Just to be super-clear :) - Elvis Stansvik On May 1

Re: Proposing myself as intermediate(sic!) maintainer of Plan

2013-04-13 Thread Elvis Stansvik
yay! Elvis 2013/4/13 Friedrich W. H. Kossebau > Hi, > > Dag nicely sent me off-list some info to use in my upcoming blog post about > the search of a new maintainer for Calligra Plan. I plan ;) to post the > blog > on monday (still need to write it). > > While playing around with Plan to learn

Re: Rename Coffice?

2013-03-25 Thread Elvis Stansvik
2013/3/25 Sebastian Sauer : > On 03/25/2013 12:32 PM, Jaroslaw Staniek wrote: >> >> hi, congrats for publicity but i'm suggesting not introducing >> redundant brands extra that sound like a fork, > > > Redundant as in Coffice contains already a C==Calligra? Yes, well. That name > refers also to my

Re: Review Request 109651: Refactor style manager

2013-03-24 Thread Elvis Stansvik
Loop 2) When adding a new style in the Style Manager, it shows up correctly in the styles combo under "Text editing". But after changing a style and hitting "Apply" in the Style Manager, the look is not updated in the

Re: Wiki build instructions updated for product sets

2013-03-24 Thread Elvis Stansvik
professional feel to them :) Elvis 2013/3/24 Friedrich W. H. Kossebau : > Hi Elvis, > > Am Sonntag, 24. März 2013, 11:13:54 schrieb Elvis Stansvik: >> Hi all, >> >> I took the liberty of updating >> >> http://community.kde.org/Calligra/Building#Building_selected_a

Wiki build instructions updated for product sets

2013-03-24 Thread Elvis Stansvik
Hi all, I took the liberty of updating http://community.kde.org/Calligra/Building#Building_selected_applications to include info about product sets. Would be nice if someone (Friedrich?) could take a short look to make sure it's correct. Was a while since I built Calligra :) Also, remember to

Re: Review Request 109651: Refactor style manager

2013-03-23 Thread Elvis Stansvik
. plugins/textshape/dialogs/StylesManagerModel.cpp <http://git.reviewboard.kde.org/r/109651/#comment22145> maybe just if (!m_styles.contains(style)), since the value of row isn't used here. - Elvis Stansvik On March 22, 2013, 4:38 a.m.,

Review Request: Load fo:margin and fo:padding shorthands before the left/right/top/bottom variants

2012-08-26 Thread Elvis Stansvik
. Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: KoXmlReader, this is bug or not

2012-08-02 Thread Elvis Stansvik
bsolutely right. I just tested and it does. So then it's up to Moji if he want's to use that solution or use firstChildElement() (which I see was added by Thorsten back in January). Thanks, Elvis > > Best Regards. > > 2012/8/2 Elvis Stansvik : >> 2012/8/2 Elvis Stansvik

Re: KoXmlReader, this is bug or not

2012-08-02 Thread Elvis Stansvik
2012/8/2 Elvis Stansvik : > 2012/8/2 mojtaba shahi Senobari : >> Hi all >> >> I was working with KoXmlReader and at a node ( just include attributes ) i >> try firstChild(). >> >> I except an element, that should be a child of my node, but no result.

Re: KoXmlReader, this is bug or not

2012-08-02 Thread Elvis Stansvik
2012/8/2 mojtaba shahi Senobari : > Hi all > > I was working with KoXmlReader and at a node ( just include attributes ) i > try firstChild(). > > I except an element, that should be a child of my node, but no result. Perhaps what you're looking for is firstChildElement() ? I think in DOM, a node

Re: Review Request: Support for path-stretchpoint-x and path-stretchpoint-y

2012-07-19 Thread Elvis Stansvik
ted it with the document in bug 258267. Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Support for path-stretchpoint-x and path-stretchpoint-y

2012-05-15 Thread Elvis Stansvik
mishap (accidental push). It has been reverted. - Elvis Stansvik On May 8, 2012, 11:20 a.m., Elvis Stansvik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: calligra-devel Digest, Vol 19, Issue 67

2012-05-14 Thread Elvis Stansvik
context based grammar checking. > > > > br, > > > > -matus uzak > The trouble with rules is that it's hard to codify a language grammar in a way > that wont give false warnings. Also as you said it is hard to maintain, not to > say it requires manual work to defin

Re: Review Request: Support for path-stretchpoint-x and path-stretchpoint-y

2012-05-08 Thread Elvis Stansvik
://git.reviewboard.kde.org/r/104804/diff/ Testing --- I tested it with the document in bug 258267. Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Text dragging in the textshapes

2012-05-05 Thread Elvis Stansvik
/to stage works here (Qt 4.8.1), so ship it! - Elvis Stansvik On April 29, 2012, 8:27 p.m., C. Boemann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Support for path-stretchpoint-x and path-stretchpoint-y

2012-05-01 Thread Elvis Stansvik
/EnhancedPathShape.cpp dc29c3a Diff: http://git.reviewboard.kde.org/r/104804/diff/ Testing --- I tested it with the document in bug 258267. Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org

Re: Review Request: Support for path-stretchpoint-x and path-stretchpoint-y

2012-05-01 Thread Elvis Stansvik
19bb1 plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp dc29c3a Diff: http://git.reviewboard.kde.org/r/104804/diff/ Testing --- I tested it with the document in bug 258267. Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-

Re: Review Request: Support for path-stretchpoint-x and path-stretchpoint-y

2012-05-01 Thread Elvis Stansvik
/enhancedpath/EnhancedPathShape.cpp dc29c3a Diff: http://git.reviewboard.kde.org/r/104804/diff/ Testing --- I tested it with the document in bug 258267. Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org

Review Request: Support for path-stretchpoint-x and path-stretchpoint-y

2012-05-01 Thread Elvis Stansvik
258267. Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Wikipedia preparation for 2.4 release

2012-04-11 Thread Elvis Stansvik
Den 11 april 2012 14:49 skrev Friedrich W. H. Kossebau : > Am Mittwoch, 11. April 2012, 13:42:55 schrieb Markus: >> Am Mittwoch 11 April 2012, 13:19:49 schrieb Friedrich W. H. Kossebau: >> > So this is how Wikipedia works these days, everyone writes articles about >> > their own stuff? >> >> Well,

Re: [calligra] /: Make paragraph and character dialogs actually work, and use the new visitor

2012-03-11 Thread Elvis Stansvik
2012/3/11 Inge Wallin : > On Saturday, March 10, 2012 10:52:04 Elvis Stansvik wrote: >> 2012/3/9 C. Boemann : >> > Could someone please review and take it for a spin so i can backport it >> >> Works fine here. Tested on single and multiple paragraphs and >> un

Review Request: Reduce code duplication in KoTextDocumentLayout::doLayout() a bit

2012-03-10 Thread Elvis Stansvik
--- Unit tests. Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: [calligra] /: Make paragraph and character dialogs actually work, and use the new visitor

2012-03-10 Thread Elvis Stansvik
2012/3/9 C. Boemann : > Could someone please review and take it for a spin so i can backport it Works fine here. Tested on single and multiple paragraphs and undo/redo. Please backport. Side note: At the moment it's impossible to e.g. directly format e.g. the underlining of a paragraph while stil

Re: Using the Tables brand/trade name for a spreadsheet application

2012-03-07 Thread Elvis Stansvik
2012/3/8 Marijn Kruisselbrink : > On Thursday, March 08, 2012 04:36:25 AM Sebastian Sauer wrote: >> On 03/07/2012 06:10 PM, Algot Runeman wrote: >> > On 03/07/2012 09:15 AM, Boudewijn Rempt wrote: >> >> On Wed, 7 Mar 2012, Sebastian Sauer wrote: >> >>> I really think we should not rename to Abacus

Re: Using the Tables brand/trade name for a spreadsheet application

2012-03-07 Thread Elvis Stansvik
2012/3/7 Sebastian Sauer : > On 03/07/2012 12:14 PM, Sebastian Sauer wrote: >> >> 10. Numbers n shit loses to Abacus by 8–0, loses to Flats by 4–2 >> => I would not see that as serious proposal, or? I mean I think an >> application should not be named "shit"... maybe make it "sheet" if you like >>

Re: Review Request: Maintain text selection through undo/redo

2012-02-29 Thread Elvis Stansvik
tically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104098/#review10955 --- On Feb. 27, 2012, 5:03 p.m., Elvis Stansvik wrote: > > --- > This is an automa

Re: Review Request: load and save draw:id and text:id also as xml:id

2012-02-29 Thread Elvis Stansvik
74/#comment8929> else on same row libs/odf/KoElementReference.h <http://git.reviewboard.kde.org/r/104074/#comment8930> why not camel case for these enum values? words/part/KWOdfWriter.cpp <http://git.reviewboard.kde.org/r/104074/#comment8931> else on same row

Review Request: Maintain text selection through undo/redo

2012-02-27 Thread Elvis Stansvik
redoing the operations. The selection is maintained. Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Update block formats on paragraph style change

2012-02-24 Thread Elvis Stansvik
ldn't override the direct formatting. Thanks, Elvis Stansvik ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

  1   2   >