-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122254/
-----------------------------------------------------------
(Updated Jan. 25, 2015, 11:07 p.m.)
Status
------
This change has been marked as submitted.
Review request for Calligra, Camilla Boemann and Inge Wallin.
Bugs: 303492
http://bugs.kde.org/show_bug.cgi?id=303492
Repository: calligra
Description
-------
This patch makes sure that the text editor's DeleteCommand removes inline
objects from the KoInlineTextObjectManager when the user removes them.
With the patch applied, end notes are correctly removed when you remove their
reference in the main text. It thus fixes bug #303492.
The reason I'm putting it up for review is that:
1. I'm not 100% sure the fix is correct.
2. I'm still confused as to why it seemingly works to remove foot notes at the
moment, and not end notes. It would seem to me it shouldn't work for either of
them.
Diffs
-----
libs/kotext/commands/DeleteCommand.h f6faad2
libs/kotext/commands/DeleteCommand.cpp 7c69df7
Diff: https://git.reviewboard.kde.org/r/122254/diff/
Testing
-------
I tested adding/removing footnotes and endnotes in various places, and removing
them by backspacing/deleting across their references, or selecting a bunch of
references with the mouse and hitting backspace/delete. Both footnotes and
endnotes were removed from the bottom of the page/document.
Thanks,
Elvis Stansvik
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
