----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110129/#review32421 -----------------------------------------------------------
Looks safe, but someone else will have to "Ship it". libs/main/KoMainWindow.h <http://git.reviewboard.kde.org/r/110129/#comment24100> I suggest: s/windows/window/ s/may be opened/may have been opened/ s/the window/this window/ Unless I misunderstood. Just to be super-clear :) - Elvis Stansvik On May 1, 2013, 7:59 a.m., Dmitry Kazakov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110129/ > ----------------------------------------------------------- > > (Updated May 1, 2013, 7:59 a.m.) > > > Review request for Calligra. > > > Description > ------- > > I have added a signal which is emitted when KoMainWindow finishes loading of > the document. This is needed, because the loading of remote (via http and > etc.) documents happens asynchronously, and we need to know when we can > remove the old window, because it has some links with it. > > This fixes the bug: > https://bugs.kde.org/show_bug.cgi?id=318560 > > Pushed into my branch: > http://commits.kde.org/calligra/c49444def062bc37435992fb7546c944c754f6b6 > > > Diffs > ----- > > krita/ui/kis_import_catcher.h 9be44ca > krita/ui/kis_import_catcher.cc 8224df8 > krita/ui/kis_view2.cpp 9108c35 > libs/main/KoMainWindow.h 550ab33 > libs/main/KoMainWindow.cpp a739cbb > > Diff: http://git.reviewboard.kde.org/r/110129/diff/ > > > Testing > ------- > > Testing done with Krita only. But it doesn't change anythink for other > applications. > > > Thanks, > > Dmitry Kazakov > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
