----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111326/#review35331 -----------------------------------------------------------
Nice patch. Having it configurable might be asking for trouble IMO, as 3rd parties should be able to rely on the headers being at a fixed location. For the second question; I think it makes sense to put everything under calligra/, but I'll let more people chime in on that. - Elvis Stansvik On June 30, 2013, 9:38 p.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111326/ > ----------------------------------------------------------- > > (Updated June 30, 2013, 9:38 p.m.) > > > Review request for Calligra. > > > Description > ------- > > While almost all headers of Calligra libs are prefixed with "Ko"/"ko" it > feels better to install them to their own subdir named "calligra/": > * Easier for people using the libs and wanting to browse through all the > available headers (until we improve > http://api.kde.org/bundled-apps-api/calligra-apidocs/) > * Easier also for developers to just remove the complete calligra/ dir to > clean up > * subdirs "styles/" & "changetracker/" are used by kotext headers, which > feels strange directly in the normal include dir, without any prefix > > Questions: > * Should that "calligra/" be made a configuration option? Who might need/want > change that to something else? > * Should all the other apps also install below calligra/$APP, or continue to > use "words/", "sheets/", "stage/" etc.? > > > Diffs > ----- > > CMakeLists.txt 2504353 > interfaces/CMakeLists.txt 36eb42a > libs/basicflakes/CMakeLists.txt 4750c5f > libs/flake/CMakeLists.txt 233d3ce > libs/kopageapp/CMakeLists.txt deb7d76 > libs/kotext/CMakeLists.txt 8929d8a > libs/kundo2/CMakeLists.txt cf66a13 > libs/main/CMakeLists.txt 147b25c > libs/odf/CMakeLists.txt 574f8a5 > libs/pigment/CMakeLists.txt 8cc00e8 > libs/rdf/CMakeLists.txt 875ce13 > libs/textlayout/CMakeLists.txt cf2b83b > libs/widgets/CMakeLists.txt 38155e7 > libs/widgetutils/CMakeLists.txt bfe64ca > > Diff: http://git.reviewboard.kde.org/r/111326/diff/ > > > Testing > ------- > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
