zhjwpku commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1879216891
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dis
pan3793 commented on code in PR #11731:
URL: https://github.com/apache/iceberg/pull/11731#discussion_r1879240394
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/IcebergArrowColumnVector.java:
##
@@ -59,6 +59,11 @@ public void close() {
accessor.cl
Ppei-Wang commented on code in PR #11729:
URL: https://github.com/apache/iceberg/pull/11729#discussion_r1879246100
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java:
##
@@ -562,6 +562,67 @@ public void readFromViewWithCTE() throws
N
liurenjie1024 commented on issue #754:
URL: https://github.com/apache/iceberg-rust/issues/754#issuecomment-2533507061
> please assign this to me if it's not a feature that needs to be released
soon. I can work on it part-time, but I cannot guarantee the completion time
Done, thanks!
huaxingao commented on code in PR #11737:
URL: https://github.com/apache/iceberg/pull/11737#discussion_r1879274285
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##
@@ -1214,6 +1214,15 @@ public void testInvalidOptions() {
pan3793 commented on code in PR #11731:
URL: https://github.com/apache/iceberg/pull/11731#discussion_r1879272199
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/IcebergArrowColumnVector.java:
##
@@ -59,6 +59,11 @@ public void close() {
accessor.cl
liurenjie1024 commented on issue #732:
URL: https://github.com/apache/iceberg-rust/issues/732#issuecomment-2533556499
Thanks for @c-thiel for raising this. I agree that we should focus on v2
first, and add v1 support later.
--
This is an automated message from the Apache Git Service.
To r
singhpk234 commented on code in PR #11731:
URL: https://github.com/apache/iceberg/pull/11731#discussion_r1879265358
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/IcebergArrowColumnVector.java:
##
@@ -59,6 +59,11 @@ public void close() {
accessor
pan3793 commented on code in PR #11731:
URL: https://github.com/apache/iceberg/pull/11731#discussion_r1879272199
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/IcebergArrowColumnVector.java:
##
@@ -59,6 +59,11 @@ public void close() {
accessor.cl
manuzhang commented on code in PR #11737:
URL: https://github.com/apache/iceberg/pull/11737#discussion_r1879291362
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##
@@ -1214,6 +1214,15 @@ public void testInvalidOptions() {
pan3793 commented on PR #11731:
URL: https://github.com/apache/iceberg/pull/11731#issuecomment-2533597688
FYI @LuciferYang @viirya @dongjoon-hyun @wForget
CI is green now, and I think the current Spark `branch-3.5` is in good shape
for Iceberg.
--
This is an automated message from
dramaticlly commented on PR #11719:
URL: https://github.com/apache/iceberg/pull/11719#issuecomment-2533650691
> This makes sense to me. How about other metadata tables? @dramaticlly do
you also want take a look?
Happy to help with other metadata tables experienced similar problem if i
ajantha-bhat opened a new issue, #11746:
URL: https://github.com/apache/iceberg/issues/11746
### Feature Request / Improvement
more information
https://lists.apache.org/thread/4kknk8mvnffbmhdt63z8t4ps0mt1jbf4
### Query engine
None
### Willingness to contribute
ajantha-bhat commented on issue #11746:
URL: https://github.com/apache/iceberg/issues/11746#issuecomment-2533652976
Will keep it open if anyone wants to take it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
sungwy commented on issue #706:
URL: https://github.com/apache/iceberg-rust/issues/706#issuecomment-2531897325
Hi @Sl1mb0 - Thank you for raising this issue!
I took a look at this issue in order to resolve all issues blocking the
0.4.0 release. I put up the PR #772 to replicate your i
gaborkaszab commented on code in PR #11738:
URL: https://github.com/apache/iceberg/pull/11738#discussion_r1878337162
##
core/src/main/java/org/apache/iceberg/CachingCatalog.java:
##
@@ -144,14 +144,16 @@ public Table loadTable(TableIdentifier ident) {
return cached;
amogh-jahagirdar commented on code in PR #11565:
URL: https://github.com/apache/iceberg/pull/11565#discussion_r1878222555
##
gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSFileIO.java:
##
@@ -242,4 +248,106 @@ private void internalDeleteFiles(Stream
blobIdsToDelete) {
Str
amogh-jahagirdar commented on code in PR #11565:
URL: https://github.com/apache/iceberg/pull/11565#discussion_r1878222555
##
gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSFileIO.java:
##
@@ -242,4 +248,106 @@ private void internalDeleteFiles(Stream
blobIdsToDelete) {
Str
raulcd commented on code in PR #7:
URL: https://github.com/apache/iceberg-cpp/pull/7#discussion_r1877940138
##
.github/workflows/test.yml:
##
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE
jiakai-li opened a new issue, #1421:
URL: https://github.com/apache/iceberg-python/issues/1421
### Apache Iceberg version
None
### Please describe the bug 🐞
When I was learning the code, I noticed currently the `DataScan` class
doesn't respect `case_sensitive` when it pl
viirya commented on PR #11731:
URL: https://github.com/apache/iceberg/pull/11731#issuecomment-2532346946
Please check for some discussion there
https://github.com/apache/spark/pull/49131#issuecomment-2532341673
--
This is an automated message from the Apache Git Service.
To respond to the
jiakai-li commented on issue #1421:
URL:
https://github.com/apache/iceberg-python/issues/1421#issuecomment-2532341957
Can I work on this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
raulcd commented on code in PR #7:
URL: https://github.com/apache/iceberg-cpp/pull/7#discussion_r1878524143
##
.github/workflows/test.yml:
##
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE
wmoustafa commented on code in PR #11365:
URL: https://github.com/apache/iceberg/pull/11365#discussion_r1878540920
##
format/view-spec.md:
##
@@ -97,7 +97,10 @@ Summary is a string to string map of metadata about a view
version. Common metad
View definitions can be represent
amogh-jahagirdar opened a new pull request, #11744:
URL: https://github.com/apache/iceberg/pull/11744
Same as https://github.com/apache/iceberg/pull/11563, removing the remaining
usages of the path API
--
This is an automated message from the Apache Git Service.
To respond to the message,
pvary merged PR #11662:
URL: https://github.com/apache/iceberg/pull/11662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
pvary commented on PR #11662:
URL: https://github.com/apache/iceberg/pull/11662#issuecomment-2532940822
Thanks @Guosmilesmile for the PR, and @mxm and @stevenzwu for the review!
@Guosmilesmile please prepare the backport commits to the other Flink
versions.
Thanks, Peter
--
rahil-c commented on PR #11180:
URL: https://github.com/apache/iceberg/pull/11180#issuecomment-2532789316
@rdblue @danielcweeks Was wondering if you guys can take a look whenever you
get a chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
dramaticlly commented on PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#issuecomment-2533061166
@rdblue @danielcweeks can you help take anther look to see if we can move
forward on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the messa
ebyhr commented on code in PR #11729:
URL: https://github.com/apache/iceberg/pull/11729#discussion_r1879148802
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java:
##
@@ -562,6 +562,67 @@ public void readFromViewWithCTE() throws
NoSuc
dramaticlly commented on issue #11741:
URL: https://github.com/apache/iceberg/issues/11741#issuecomment-2533365254
I think use this we can reproduce the problem in a unit test from
`org.apache.iceberg.spark.sql.TestCreateTable` as it support all of
hive/spark/hadoop/rest catalog, I think re
danielcweeks commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1879074770
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,43 @@ private void validateTableIsIcebergTableOrView(
}
}
+
danielcweeks commented on PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#issuecomment-2533223559
@dramaticlly minor comment, but other than that LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
dramaticlly commented on code in PR #11597:
URL: https://github.com/apache/iceberg/pull/11597#discussion_r1879086639
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##
@@ -412,6 +412,43 @@ private void validateTableIsIcebergTableOrView(
}
}
+
jiayuasu commented on code in PR #10981:
URL: https://github.com/apache/iceberg/pull/10981#discussion_r1879088058
##
format/spec.md:
##
@@ -1633,3 +1656,15 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time queri
jiayuasu commented on code in PR #10981:
URL: https://github.com/apache/iceberg/pull/10981#discussion_r1879080772
##
format/spec.md:
##
@@ -1633,3 +1656,15 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time queri
jiayuasu commented on code in PR #10981:
URL: https://github.com/apache/iceberg/pull/10981#discussion_r187907
##
format/spec.md:
##
@@ -1633,3 +1656,15 @@ might indicate different snapshot IDs for a specific
timestamp. The discrepancie
When processing point in time queri
jiakai-li opened a new pull request, #1423:
URL: https://github.com/apache/iceberg-python/pull/1423
**This pull request fixes below issue:**
- #1421
The change modified the `DataScan._build_partition_projection` method to
pass `case_sensitive` argument when calling `inclusive_proj
github-actions[bot] commented on issue #10401:
URL: https://github.com/apache/iceberg/issues/10401#issuecomment-2533325043
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache
github-actions[bot] commented on issue #10487:
URL: https://github.com/apache/iceberg/issues/10487#issuecomment-2533325230
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occur
github-actions[bot] closed issue #10401: Support for loading different
hive-metastore versions at Runtime
URL: https://github.com/apache/iceberg/issues/10401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
github-actions[bot] commented on PR #10669:
URL: https://github.com/apache/iceberg/pull/10669#issuecomment-2533325348
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
github-actions[bot] commented on PR #10862:
URL: https://github.com/apache/iceberg/pull/10862#issuecomment-2533325429
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
ebyhr commented on code in PR #11744:
URL: https://github.com/apache/iceberg/pull/11744#discussion_r1879109181
##
flink/v1.19/flink/src/test/java/org/apache/iceberg/flink/TestHelpers.java:
##
@@ -602,7 +602,7 @@ public static void assertEquals(ContentFile expected,
ContentFile
Fokko commented on code in PR #539:
URL: https://github.com/apache/iceberg-python/pull/539#discussion_r1879010689
##
pyiceberg/transforms.py:
##
@@ -766,6 +858,47 @@ def _truncate_number(
return None
+def _truncate_number_strict(
+name: str, pred: BoundLiteralPr
szehon-ho commented on PR #10981:
URL: https://github.com/apache/iceberg/pull/10981#issuecomment-2533103710
Update, there was a sync with @jiayuasu @flyrain @dmitrykoval @paleolimbot
@rdblue and Menelaos, it was decided the following (meeting notes):
My summary is that we decided to h
Fokko commented on code in PR #539:
URL: https://github.com/apache/iceberg-python/pull/539#discussion_r1879028369
##
pyiceberg/transforms.py:
##
@@ -766,6 +858,47 @@ def _truncate_number(
return None
+def _truncate_number_strict(
+name: str, pred: BoundLiteralPr
Fokko commented on code in PR #5:
URL: https://github.com/apache/iceberg-cpp/pull/5#discussion_r1879041334
##
cmake-format.py:
##
@@ -0,0 +1,74 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dis
zhjwpku commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1879216891
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dis
zhjwpku commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1879216891
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dis
pan3793 commented on PR #11731:
URL: https://github.com/apache/iceberg/pull/11731#issuecomment-2533468089
@viirya @LuciferYang thank you for the guidance, let me try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
amogh-jahagirdar merged PR #11420:
URL: https://github.com/apache/iceberg/pull/11420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
hsiang-c commented on PR #11420:
URL: https://github.com/apache/iceberg/pull/11420#issuecomment-2533470077
Thank you @amogh-jahagirdar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
xxchan opened a new pull request, #775:
URL: https://github.com/apache/iceberg-rust/pull/775
Signed-off-by: xxchan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
wzx140 opened a new issue, #11747:
URL: https://github.com/apache/iceberg/issues/11747
### Apache Iceberg version
main (development)
### Query engine
Spark
### Please describe the bug 🐞
There is a mismatch between the test comment and the assertion in the
f
sdd commented on code in PR #652:
URL: https://github.com/apache/iceberg-rust/pull/652#discussion_r1879516829
##
crates/iceberg/src/scan.rs:
##
@@ -951,6 +1077,82 @@ impl FileScanTask {
}
}
+type DeleteFileManagerResult =
Result>>>;
+
+/// Manages async retrieval of all
jkolash commented on PR #11743:
URL: https://github.com/apache/iceberg/pull/11743#issuecomment-2532509896
Closing this as I now see I can just set the
spark.sql.catalog.default_iceberg property will add more detail to the issue
--
This is an automated message from the Apache Git Service.
jkolash closed issue #11742:
org.apache.iceberg.spark.source.IcebergSource.setupDefaultSparkCatalogs
shouldn't default to hive catalog
URL: https://github.com/apache/iceberg/issues/11742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
JanKaul commented on code in PR #11365:
URL: https://github.com/apache/iceberg/pull/11365#discussion_r1878651163
##
format/view-spec.md:
##
@@ -97,7 +97,10 @@ Summary is a string to string map of metadata about a view
version. Common metad
View definitions can be represented
nastra merged PR #11721:
URL: https://github.com/apache/iceberg/pull/11721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
barronw commented on issue #1420:
URL:
https://github.com/apache/iceberg-python/issues/1420#issuecomment-2531604338
Can I pick this up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
adutra commented on code in PR #10753:
URL: https://github.com/apache/iceberg/pull/10753#discussion_r1878163433
##
core/src/main/java/org/apache/iceberg/rest/auth/AuthSession.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
aihuaxu commented on code in PR #11415:
URL: https://github.com/apache/iceberg/pull/11415#discussion_r1878440484
##
core/src/main/java/org/apache/iceberg/variants/ShreddedObject.java:
##
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
aihuaxu commented on code in PR #11415:
URL: https://github.com/apache/iceberg/pull/11415#discussion_r1878469751
##
core/src/main/java/org/apache/iceberg/variants/PrimitiveWrapper.java:
##
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
amogh-jahagirdar commented on code in PR #11565:
URL: https://github.com/apache/iceberg/pull/11565#discussion_r1878209991
##
gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSFileIO.java:
##
@@ -242,4 +248,106 @@ private void internalDeleteFiles(Stream
blobIdsToDelete) {
Str
Fokko commented on issue #1420:
URL:
https://github.com/apache/iceberg-python/issues/1420#issuecomment-2531944719
@barronw certainly, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jkolash opened a new issue, #11742:
URL: https://github.com/apache/iceberg/issues/11742
### Feature Request / Improvement
https://github.com/apache/iceberg/blob/main/spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/IcebergSource.java#L239
It should default to anot
viirya commented on PR #11731:
URL: https://github.com/apache/iceberg/pull/11731#issuecomment-2532312814
Does Iceberg implement ColumnVector interface which is similar to writable
column vector or constant column vector?
--
This is an automated message from the Apache Git Service.
To resp
bennychow commented on code in PR #11365:
URL: https://github.com/apache/iceberg/pull/11365#discussion_r1878496657
##
format/view-spec.md:
##
@@ -97,7 +97,10 @@ Summary is a string to string map of metadata about a view
version. Common metad
View definitions can be represent
jkolash commented on issue #11742:
URL: https://github.com/apache/iceberg/issues/11742#issuecomment-2532329867
This is probably the simplest fix
https://github.com/apache/iceberg/pull/11743
allow users to set these properties directly
a bigger fix may be to use another catal
stubz151 closed pull request #11739: AWS: adding s3 tables catalog
URL: https://github.com/apache/iceberg/pull/11739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
raulcd commented on code in PR #7:
URL: https://github.com/apache/iceberg-cpp/pull/7#discussion_r1878388213
##
.github/workflows/test.yml:
##
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE
pitrou commented on code in PR #7:
URL: https://github.com/apache/iceberg-cpp/pull/7#discussion_r1878396289
##
.github/workflows/test.yml:
##
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE
saitharun15 commented on PR #11615:
URL: https://github.com/apache/iceberg/pull/11615#issuecomment-2532200924
Hi @RussellSpitzer ,@huaxingao can u please review the pr once, Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
sunny1154 opened a new issue, #11741:
URL: https://github.com/apache/iceberg/issues/11741
### Apache Iceberg version
1.5.0
### Query engine
Spark
### Please describe the bug 🐞
Hi,
I am observing issues when working with rest based catalog.
my
pan3793 commented on PR #11731:
URL: https://github.com/apache/iceberg/pull/11731#issuecomment-2532122346
update: the failure is related to
[SPARK-50235](https://github.com/apache/spark/pull/48767), and the test passed
on Spark 3.5.4 RC0 with reverting that patch
--
This is an automated
manuzhang commented on code in PR #11123:
URL: https://github.com/apache/iceberg/pull/11123#discussion_r1877751060
##
core/src/main/java/org/apache/iceberg/CachingCatalog.java:
##
@@ -145,22 +146,26 @@ public Table loadTable(TableIdentifier ident) {
}
if (MetadataTab
manuzhang commented on code in PR #11654:
URL: https://github.com/apache/iceberg/pull/11654#discussion_r185553
##
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java:
##
@@ -421,7 +423,13 @@ public void testConcurrentFastAppends(@TempDir File dir)
throws Exc
JanKaul commented on code in PR #11365:
URL: https://github.com/apache/iceberg/pull/11365#discussion_r186853
##
format/view-spec.md:
##
@@ -97,7 +97,10 @@ Summary is a string to string map of metadata about a view
version. Common metad
View definitions can be represented
jkolash closed pull request #11743: WIP proposal for fixing issue #11742
URL: https://github.com/apache/iceberg/pull/11743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
jkolash commented on issue #11742:
URL: https://github.com/apache/iceberg/issues/11742#issuecomment-2532512695
ok setting
spark.sql.catalog.default_iceberg=org.apache.iceberg.spark.SparkCatalog
will allow you to override the default values.
--
This is an automated message f
LuciferYang commented on PR #11731:
URL: https://github.com/apache/iceberg/pull/11731#issuecomment-2532512457
> Please check for some discussion there [apache/spark#49131
(comment)](https://github.com/apache/spark/pull/49131#issuecomment-2532341673)
Yes, I tested it locally and found
Ppei-Wang commented on code in PR #11729:
URL: https://github.com/apache/iceberg/pull/11729#discussion_r1877165202
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java:
##
@@ -562,6 +562,58 @@ public void readFromViewWithCTE() throws
N
JanKaul commented on code in PR #11041:
URL: https://github.com/apache/iceberg/pull/11041#discussion_r1877723130
##
format/view-spec.md:
##
@@ -160,6 +179,56 @@ Each entry in `version-log` is a struct with the following
fields:
| _required_ | `timestamp-ms` | Timestamp when t
Fokko commented on code in PR #11728:
URL: https://github.com/apache/iceberg/pull/11728#discussion_r1877861454
##
api/src/main/java/org/apache/iceberg/types/Types.java:
##
@@ -412,6 +413,24 @@ public String toString() {
}
}
+ public static class NullType extends Primi
Fokko commented on PR #768:
URL: https://github.com/apache/iceberg-rust/pull/768#issuecomment-2531216814
@jonathanc-n Could you rebase the PR? I'll merge it right away after that 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
Fokko closed pull request #763: Simplify partition structures
URL: https://github.com/apache/iceberg-rust/pull/763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
Fokko commented on PR #763:
URL: https://github.com/apache/iceberg-rust/pull/763#issuecomment-2531222156
Closed in favor of https://github.com/apache/iceberg-rust/pull/771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
manuzhang commented on code in PR #11738:
URL: https://github.com/apache/iceberg/pull/11738#discussion_r1878295947
##
core/src/main/java/org/apache/iceberg/CachingCatalog.java:
##
@@ -144,14 +144,16 @@ public Table loadTable(TableIdentifier ident) {
return cached;
}
Fokko commented on issue #1418:
URL:
https://github.com/apache/iceberg-python/issues/1418#issuecomment-2531608924
@djouallah do you know which version of Pydantic you're using? You can
easily check it using:
```
Python 3.10.14 (main, Mar 19 2024, 21:46:16) [Clang 15.0.0
(clang-15
Fokko merged PR #1419:
URL: https://github.com/apache/iceberg-python/pull/1419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceber
gaborkaszab commented on code in PR #7:
URL: https://github.com/apache/iceberg-cpp/pull/7#discussion_r1878384745
##
.github/workflows/test.yml:
##
@@ -0,0 +1,95 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the N
nastra commented on code in PR #10753:
URL: https://github.com/apache/iceberg/pull/10753#discussion_r1878738170
##
core/src/main/java/org/apache/iceberg/rest/auth/AuthSession.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
raulcd commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1877791436
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dist
pitrou commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1877805402
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# dist
gaborkaszab commented on code in PR #4:
URL: https://github.com/apache/iceberg-cpp/pull/4#discussion_r1877769090
##
.clang-format:
##
@@ -0,0 +1,22 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+#
hsiang-c commented on code in PR #11420:
URL: https://github.com/apache/iceberg/pull/11420#discussion_r1877559085
##
aws/src/test/java/org/apache/iceberg/aws/kms/TestKmsClientProperties.java:
##
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
findepi commented on code in PR #11721:
URL: https://github.com/apache/iceberg/pull/11721#discussion_r1877655052
##
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/data/TestRowProjection.java:
##
@@ -369,19 +346,7 @@ public void testMapProjection() throws IOException {
Fokko commented on code in PR #771:
URL: https://github.com/apache/iceberg-rust/pull/771#discussion_r1877888621
##
crates/iceberg/src/spec/table_metadata.rs:
##
@@ -119,9 +119,11 @@ pub struct TableMetadata {
/// ID of the table’s current schema.
pub(crate) current_sch
Fokko commented on code in PR #771:
URL: https://github.com/apache/iceberg-rust/pull/771#discussion_r1877890713
##
crates/iceberg/src/spec/table_metadata.rs:
##
@@ -776,17 +782,12 @@ pub(super) mod _serde {
.map(|x| (x.spec_id(), Arc::new(x))),
1 - 100 of 147 matches
Mail list logo
