JanKaul commented on code in PR #11365: URL: https://github.com/apache/iceberg/pull/11365#discussion_r1877776853
########## format/view-spec.md: ########## @@ -97,7 +97,10 @@ Summary is a string to string map of metadata about a view version. Common metad View definitions can be represented in multiple ways. Representations are documented ways to express a view definition. -A view version can have more than one representation. All representations for a version must express the same underlying definition. Engines are free to choose the representation to use. +A view version can have more than one representation. All representations for a version must express the same underlying definition. Engines are free to choose the representation to use. For the table identifiers in the view definitions to be interoperable across engines, the following must be true: +* All engines must resolve a fully specified SQL identifier to the same table in the same catalog. Review Comment: There are two parts to consider: 1. Resolution of table references 3. Portability constraints I think @bennychow 's suggestion conflates the two. In addition to the portability constraint, it describes how a query engine should resolve a partial table reference using either the default-catalog or the view catalog. This conflicts with how table references are currently resolved in the view spec. Currently only the default-catalog is used. If the main point of this PR is to define the Portability constraints, then we should not change the resolution of table references. Changing the table reference resolution would also be a breaking change to the view spec. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
