huaxingao commented on code in PR #11737:
URL: https://github.com/apache/iceberg/pull/11737#discussion_r1879274285
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##########
@@ -1214,6 +1214,15 @@ public void testInvalidOptions() {
.hasMessageContaining("requires enabling Iceberg Spark session
extensions");
}
+ @TestTemplate
+ public void testIgnoreInvalidOptions() {
+ Table table = createTable(20);
+ basicRewrite(table)
+ .option("ignore-invalid-options", "true")
+ .option("foobarity", "-5")
+ .execute();
Review Comment:
Should we also test the default behavior of `ignore-invalid-options`,
similar to what you did in
`TestRewritePositionDeleteFilesAction.testIgnoreInvalidOptions`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
