epotyom commented on code in PR #12862: URL: https://github.com/apache/lucene/pull/12862#discussion_r1427718945
########## lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyWriter.java: ########## @@ -32,8 +32,8 @@ import org.apache.lucene.document.Field; import org.apache.lucene.document.NumericDocValuesField; import org.apache.lucene.document.StringField; +import org.apache.lucene.facet.FacetLabel; Review Comment: Oh, I thought it's ok to move it because it is labelled as `@lucene.internal`. I think merging to 10.0/main only is fine. The alternatives are: 1. Pass 2d array of path components - `String[][] pathComponents`, cons: I think it makes API slightly less intuitive/readable? 2. Create a new interface in `org.apache.lucene.facet` and pass its array - `FacetComponents[]`, cons: exposing both new interface and `FacetLabel` as public API is kind of confusing? 3. Don't move the class and import it from `...taxonomy` in all non-taxonomy facet implementations, cons: doesn't look great; But I think I still prefer current implementation a little more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
