epotyom commented on code in PR #12862:
URL: https://github.com/apache/lucene/pull/12862#discussion_r1533045638
##########
lucene/facet/src/java/org/apache/lucene/facet/LongValueFacetCounts.java:
##########
@@ -568,6 +568,12 @@ public Number getSpecificValue(String dim, String... path)
{
throw new UnsupportedOperationException();
}
+ @Override
+ public Number[] getBulkSpecificValues(FacetLabel[] facetLabels) {
+ // TODO: should we impl this?
Review Comment:
My first instinct was to do the default implementation, the same way it
works for `TaxonomyReader.getBulkPath`. But the difference is that
`TaxonomyReader` has only one implementation as of now, which makes it easier
to track that the method is overriden and it is faster than calling `getPath`
in a loop. But `Facets` class has 10+ implementations, so I'm leaning towards
not having default method to make sure each implementation optimizes it. It
will be easy to add the default method later if necessary.
I've added a note to the javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
