epotyom commented on code in PR #12862:
URL: https://github.com/apache/lucene/pull/12862#discussion_r1420763643
##########
lucene/facet/src/java/org/apache/lucene/facet/LongValueFacetCounts.java:
##########
@@ -568,6 +568,12 @@ public Number getSpecificValue(String dim, String... path)
{
throw new UnsupportedOperationException();
}
+ @Override
+ public Number[] getBulkSpecificValues(FacetLabel[] facetLabels) {
+ // TODO: should we impl this?
Review Comment:
Yes, but this class doesn't implement `getSpecificValue`. We can add it as a
default implementation maybe, to `Facets` class? But then there will be less
incentive to write faster version of `getBulkSpecificValues` for future
`Facets` subclasses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
