gsmiller commented on PR #12862: URL: https://github.com/apache/lucene/pull/12862#issuecomment-1979641229
@epotyom I saw Mike already approved. I did my own pass anyway so I understand the changes. They look good. Thanks! I left one small question for you about a default implementation. Let's resolve that open question then I'll merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
