mikemccand commented on code in PR #12862: URL: https://github.com/apache/lucene/pull/12862#discussion_r1426891701
########## lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/DirectoryTaxonomyWriter.java: ########## @@ -32,8 +32,8 @@ import org.apache.lucene.document.Field; import org.apache.lucene.document.NumericDocValuesField; import org.apache.lucene.document.StringField; +import org.apache.lucene.facet.FacetLabel; Review Comment: This is a public API break (moving `FacetLabel` up one package). I think that's fine, but I think that means we should only merge this into 10.0 / main? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
