easyice commented on code in PR #12841: URL: https://github.com/apache/lucene/pull/12841#discussion_r1422390737
########## lucene/core/src/java21/org/apache/lucene/store/MemorySegmentIndexInput.java: ########## @@ -303,6 +304,30 @@ public byte readByte(long pos) throws IOException { } } + @Override + public void readGroupVInts(long[] dst, int limit) throws IOException { + int i; + try { + for (i = 0; i <= limit - 4; i += 4) { Review Comment: I think the loop of `readVInt()` needs to stay? because we needs update position of block before `readVInt()` in different directory implementations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org