bruno-roustant commented on PR #12716: URL: https://github.com/apache/lucene/pull/12716#issuecomment-1782623703
Thank you @shubhamvishu for these experiments. The table answers exactly to the questions. And it means actually there is no point to change the bit mixing, since it does not bring any improvement. Making the rehash threshold at 1/2 would means the hash structure would occupy more memory on average since it would allocate an "array" and would use it between 25% to 50% occupancy. With the 2/3 threshold, it uses it between 33% and 66% occupancy. So staying at 2/3 is better. Sometimes an appealing idea is actually a false good idea. And it's great to have these experiments to avoid the pitfall! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
