dweiss commented on PR #12716: URL: https://github.com/apache/lucene/pull/12716#issuecomment-1815225881
The fact hash key remixing doesn't improve the situation is not necessarily a sign that it's somehow wrong - it means hash keys are distributed evenly already (which is good). Remixing adds this extra layer of confidence that even if bad hash functions are present on input, it'll still redistribute those "bad" original keys fairly uniformly. I'm surprised linear probing doesn't yield an improvement. Perhaps it's not a significant factor because of other load? Hard to say. Anyway, no need to make things more complicated if they don't yield a visible improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
