shubhamvishu commented on PR #12716: URL: https://github.com/apache/lucene/pull/12716#issuecomment-1777730978
Thanks for the quick review @mikemccand! I have addressed the comments in the new revision. > Could you also change the probe from quadratic (what it is now) to a simple linear probe (just test each +1 (wrapping at the hash table size) slot on insert collision)? > Second, could you change the rehash ratio from 2/3 -> 3/4? The better mixing should mean we can run a tighter ship here. Addressed both in the new revision > I'm happy to help test the impact to FST construction time -- I'll just run the new IndexToFST tool in luceneutil on a nightly wikimediumall index. That's a decent stress test of FST building (creates an FST ~350 MB or more, depending on how much RAM you are willing to spend while compiling it). Thank you so much for the help Mike ! I have never run the fst benchmark but seems like its straightforward java script?. I could give it a try as well (sometime this week) if you don't beat me to it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
