mikemccand commented on PR #12716: URL: https://github.com/apache/lucene/pull/12716#issuecomment-1779443135
OK I ran it twice on `main`: ``` saved FST to "fst.bin": 294815624 bytes; 59.874 sec saved FST to "fst.bin": 294815624 bytes; 60.255 sec ``` And twice with this PR: ``` saved FST to "fst.bin": 294815624 bytes; 69.026 sec saved FST to "fst.bin": 294815624 bytes; 70.082 sec ``` Net net ~ 16.7% slower (~60s -> ~70s), maybe more than I expected. Should we try just the better mixing but keep the rehash trigger at 2/3, maybe? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org