shubhamvishu opened a new pull request, #12716:
URL: https://github.com/apache/lucene/pull/12716

   ### Description
   
    Addresses #12704. Below is the comment that inspired this 
([link](https://github.com/apache/lucene/pull/12633#discussion_r1366847986)),
   
   
   ```
   Instead, we should multiply with the gold constant BitMixer#PHI_C64 (make it 
public).
   This really makes a difference in the evenness of the value distribution. 
This is one of the secrets of the HPPC hashing. By applying this, we get 
multiple advantages:
   
     * lookup should be improved (less hash collision)
     * we can try to rehash at 3/4 occupancy because the performance should not 
be impacted until this point.
     * in case of hash collision, we can lookup linearly with a pos = pos + 1 
instead of quadratic probe (lines 95 and 327); this may avoid some mem cache 
miss.
     * 
   (same for the other hash method)
   ```
   <!--
   If this is your first contribution to Lucene, please make sure you have 
reviewed the contribution guide.
   https://github.com/apache/lucene/blob/main/CONTRIBUTING.md
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to