zhaih commented on PR #12257: URL: https://github.com/apache/lucene/pull/12257#issuecomment-1539387747
@alessandrobenedetti thanks for explaining, altho I still don't like the idea of creating an `OffHeapHnswGraphSearcher` but use only APIs provided by `HnswGraph`, but to address your concern that user may not aware of there's a better searcher, I made a new change: instead of making a new `OnHeapHnswGraphSearch.search` API I overloaded the old method so that when users are using `OnHeapHnswGraph` they will automatically use the thread-safe version, how do you think about that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
