alessandrobenedetti commented on PR #12257: URL: https://github.com/apache/lucene/pull/12257#issuecomment-1541925563
I still think this contribution to be valuable, as I don't like much the fact that OnHeapGraph is stateful. But I agree that the other contribution is solving a very similar problem. @zhaih would be ok for you to try to get involved in the other contribution, trying to align your intent with the guy in there? If you don't have the time, I'll try to find some, by the end of the week, as it's a very interesting topic. In regard to avoiding people using the OnHeapHnswHraph outside the builder, I suspect we'll need to restructure the code in some way, as simple comments won't prevent future people to not using public classes. And by the way, I also agree that we can improve the Word2Vec synonym filter in the future, changing the OnHeap approach with an OffHeap one, but rather than reverting it (and very likely lose the contribution) I do believe that incremental updates are the key here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
