alessandrobenedetti commented on PR #12257: URL: https://github.com/apache/lucene/pull/12257#issuecomment-1538048692
Hi @zhaih, the main intent of my commits was not to make searching an OffHeap graph thread safe. The main problem I see at the moment is that we delegate to a comment the responsibility of indicating to users 'the better searcher for OnHeap graphs'. I looked around and we use a graph searcher, as far as I saw, it's always known of we are dealing with an OffHeap or OnHeap version. Hence the reason I made it explicit in the classes, so it won't be possible to have a choice: if you deal with the OnHeap you must use the OnHeapSearcher and if you deal with the OffHeap, you use the OffHeapSearcher. For example with your original commits the bug we have on the SynonymProvider will still be there and no compilation error will tell us there's actually a better graphSearcher for the use case. I hope this makes my contribution here clearer, and what I proposed is not meant to be the perfect solution but I believe we shouldn't ignore the problem and build a similar solution (happy to evaluate better approaches if any!) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
