alessandrobenedetti commented on PR #12257: URL: https://github.com/apache/lucene/pull/12257#issuecomment-1546607604
I agree to your points @zhaih , thinking more about it, to me this is just a minor contribution and an improvement. Although I value also Jim's insights, I don't think they are blockers and I would suggest to merge on monday (or when it pleases you Patrick) unless @jimczi has some pragmatic evidence this causes any regression. The other PR can manage to solve the conflicts later if any, that alone shouldn't block improvements like this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
