zhaih commented on PR #12257: URL: https://github.com/apache/lucene/pull/12257#issuecomment-1540613109
Sorry @jimczi I am not sure I get your idea. Did you mean: 1. We shouldn't make improvement to this OnHeapHnswGraph right now because the other PR is ongoing and it will likely replace this one so what we're doing here will be deprecated eventually. Or: 2. We shouldn't make improvement to this OnHeapHnswGraph for reason that is not for our main use case: which is indexing. I actually don't think this PR is that related to the other one, actually this one can be benefit to the other one as that one is currently using `ThreadLocal` internally to solve the problem this PR is solving. If this PR is checked in, I believe the other one might be able to abandon the `ThreadLocal`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
