gsmiller commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1162137822
OK, I think I understand the intention with `FSD` long/int decoding more, but I think it could be a little confusing in the API currently. If I was a user, I'd expect there to be four implementations that correspond with the four types being supported out-of-the-box (int/long/float/double). But this is _really_ about knowing the width of the encoded "sortable longs" in the doc value field. So, with my better understanding, 1) I think the current approach is reasonable, and I can't think of any better suggestion, but 2) maybe we could update the javadocs in `FSD` to make it a little more clear it's about decoding the stored bytes into *comparable longs*? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
