gsmiller commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1151548324
Regarding this "long matches API", I'm fairly confused. Why would we need this? I think I'm missing a chunk of previous conversation? But looking at this latest code, I can't imagine why we'd need this? Is this about providing enough information to optimize with KD/R-Trees? If that's the case, I don't think we want a `matches(long[])` method right? We just need a way for the `FSM` instances to expose their bounding-boxes. I don't think we even need to store the original long[] array to do this. But I don't think we need to hash that out here. So unless I'm totally missing something, I think we should keep the `matches(byte[])` method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
