mdmarshmallow commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1149153824
I want to summarize the open questions we have right now to help figure out what we should do next: 1. Should we split the `ExactFSM` and range multidim implementations into separate packages (`facetset` for the exact implementation and `hyperrectangle` for the range implementation) or the same? 2. As @shaie mentioned, should we have a `long[]` based API or not? For the first one, I talked with Greg a bit more about his suggestion to have them in separate packages and I think I agree with this. We can then make more specialized subclasses (like `DoubleExactFSM` and `DoubleHyperRectangle`) without cluttering up the package, and optimizations won't have to account for the fact we could be doing exact matching vs range matching etc. Maybe we combine them in the future? But I think for now we should keep them separate. For the second question, I think we should keep this as a `long[]` based API as we know we want to make the KD tree and R tree optimizations in the future, so adding extra work for us to have to revert doesn't make sense to me? Though if you guys have contrary opinions please let me know, I could see other viewpoints for this. I think once we come to agreement on these questions it will be a lot easier to move forward, at least for me cause I think it will help me have a greater understanding of exactly what our final product (for this PR at least) should look like. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
