shaie commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1153078375
> pushed a change just now that shows a different way we _could_ approach this. If I understand your change correctly, then it creates a new `long[]` in each call to `matches()` right? I see two main problems here: 1. It will potentially create millions of these small transient arrays if there are many hits and few facet sets per her. 2. If there's more than one `FSM` then each one will decode the `byte[]` itself, right? Do you see any advantage of this impl over the one I pushed? BTW, we can remove the `numDims` parameter from my `matches(long[])` version, since `numDims == dimValues.length`, so it's redundant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
