mdmarshmallow commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1148871572
Hey Greg, I had a question about point 4. Are you saying we should have a separate hyper rectangle implementation in addition to facet sets in order to implement the R-tree and KD-tree optimizations? I actually addressed this above but I think we can just implement those in facet sets (specifically `MatchingFacetSetCounts`) right? Couldn't we have the class do put `RangeFSM` into R-trees and `ExactFSM` into KD-trees and that would fix the issue you are talking about here? I could be misunderstanding something so let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org