shaie commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1149113591
> look forward to seeing the "range" implementation sketched out I pushed a commit w/ `RangeFacetSetMatcher` which is basically very similar to `HyperRectangle`, but w/ some different names (i.e. `LongRange` instead of `LongPair`). I've also refactored the tests into 3 classes: a general test case for `MatchingFacetSetCounts` and two classes for `Exact/RangeFacetSetMatcher`. The tests are not exhaustive yet, and the impl still lacks a `Double` variant. Do we want to consider moving to a `long[]` based matching API now? To allow for future optimizations like R/KD-Trees? Or proceed w/ the `byte[]` version for now (to finalize this PR, and until the need arises)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
