shaie commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1151141806
@gsmiller, @mdmarshmallow I pushed another commit with the following changes: 1. Assertion that all read facet sets have the same dimensionality (it's currently an `assert` to not affect runtime performance, but I think that if all is Kosher, most of these checks will be predicted correctly by the CPU?) 2. Added another `matches(long[])` API so we can have a look at both variants. I also added a `countLongs` to `MFSC` and a TEMP constructor parameter to count either bytes or longs. After we decide whether to stick w/ the `long[]` or `byte[]` API we'll remove the unneeded variant. Tests pass (I verified both bytes and long counting logic were executed). I think that if we initialize the `long[]` once there's no performance overhead to working with longs? And the impls are much shorter and simpler? Anyway, now we have both versions to review, hopefully it will ease making a decision :). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
