noblepaul commented on a change in pull request #1109: More pervasive use of
PackageLoader / PluginInfo
URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361375529
##########
File path: solr/core/src/java/org/apache/solr/schema/IndexSchemaFactory.java
##########
@@ -62,7 +62,7 @@ public static IndexSchema buildIndexSchema(String
resourceName, SolrConfig confi
PluginInfo info = config.getPluginInfo(IndexSchemaFactory.class.getName());
IndexSchemaFactory factory;
if (null != info) {
- factory = config.getResourceLoader().newInstance(info.className,
IndexSchemaFactory.class);
+ factory = config.getResourceLoader().newInstance(info,
IndexSchemaFactory.class);
Review comment:
> There is no right/wrong here; we are exploring what the future holds
together; it has not been written yet with no spec to judge right/wrong
"SRL has no idea which version of package should be loaded".
This was my statement. I never said SRL loading classes is "plain wrong".
According to the PR it was loading the latest version of the package and "that
is wrong". Am I supposed to comment on what the PR will look like in the future
or am I supposed to make comments on what it does today?
I think you are working during the holidays and you are not reading the
comments fully
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]