dsmiley commented on a change in pull request #1109: More pervasive use of 
PackageLoader / PluginInfo
URL: https://github.com/apache/lucene-solr/pull/1109#discussion_r361064071
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java
 ##########
 @@ -954,4 +987,46 @@ public static void persistConfLocally(SolrResourceLoader 
loader, String resource
     }
   }
 
+  // TODO document these methods...
 
 Review comment:
   I came to think of the SolrResourceLoader as being rather related to 
packages.  SRL has methods that lookup class names to actual Classes and then 
instances, so the focal point of my approach is to have `findClass` here work 
with the package system.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to