rdblue commented on code in PR #12672: URL: https://github.com/apache/iceberg/pull/12672#discussion_r2049763847
########## core/src/test/java/org/apache/iceberg/TestManifestWriterVersions.java: ########## @@ -213,27 +228,125 @@ public void testV2ManifestRewriteWithInheritance() throws IOException { checkRewrittenEntry(readManifest(manifest2), 0L, FileContent.DATA); } + @Test + public void testV3Write() throws IOException { + ManifestFile manifest = writeManifest(3); + checkEntry( + readManifest(manifest), + ManifestWriter.UNASSIGNED_SEQ, + ManifestWriter.UNASSIGNED_SEQ, + FileContent.DATA, + FIRST_ROW_ID); + } + + @Test + public void testV3WriteWithInheritance() throws IOException { Review Comment: This tests v2 inheritance as well and adds row IDs to the existing checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org