RussellSpitzer commented on code in PR #12672:
URL: https://github.com/apache/iceberg/pull/12672#discussion_r2019315166
##########
core/src/main/java/org/apache/iceberg/InheritableMetadataFactory.java:
##########
@@ -50,13 +52,19 @@ static class BaseInheritableMetadata implements
InheritableMetadata {
private final long snapshotId;
private final long sequenceNumber;
private final String manifestLocation;
+ private Long nextRowId;
Review Comment:
I haven't thought through all the usages but should we have this be atomic?
I think we may need handle multiple threads using this class at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
