RussellSpitzer commented on code in PR #12672:
URL: https://github.com/apache/iceberg/pull/12672#discussion_r2019425272
##########
core/src/test/java/org/apache/iceberg/TestManifestListVersions.java:
##########
@@ -248,10 +377,12 @@ public void testManifestsWithoutRowStats() throws
IOException {
assertThat(manifest.hasDeletedFiles()).isTrue();
assertThat(manifest.deletedFilesCount()).isEqualTo(4);
assertThat(manifest.deletedRowsCount()).isNull();
+ assertThat(manifest.firstRowId()).isNull();
}
- @Test
- public void testManifestsPartitionSummary() throws IOException {
+ @ParameterizedTest
+ @ValueSource(ints = {1, 2, MAX_FORMAT_VERSION})
Review Comment:
We have a field that covers 1 -> max called ALL_VERSIONS
```java
@FieldSource("org.apache.iceberg.TestHelpers#ALL_VERSIONS")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
