lliangyu-lin commented on code in PR #12671:
URL: https://github.com/apache/iceberg/pull/12671#discussion_r2023216967
##########
aws/src/integration/java/org/apache/iceberg/aws/dynamodb/TestDynamoDbCatalog.java:
##########
@@ -56,8 +58,8 @@
import software.amazon.awssdk.services.s3.model.HeadObjectRequest;
import software.amazon.awssdk.services.s3.model.NoSuchKeyException;
-public class TestDynamoDbCatalog {
Review Comment:
Yeah, that's valid points... I think iceberg-python only uses [mock
tests](https://github.com/apache/iceberg-python/blob/4d4714a46241d0d89519a2a605dbce27b713a60e/pyproject.toml#L95)
since they can be enabled in the CI pipeline.
But at least for this PR, we could extend the S3 integration tests to use
MinIO in a separate group, since that's well supported, and enable those tests
in CI pipeline. What do you think @xiaoxuandev ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
