lliangyu-lin commented on code in PR #12671:
URL: https://github.com/apache/iceberg/pull/12671#discussion_r2019130113
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##########
@@ -290,6 +290,10 @@ public class S3FileIOProperties implements Serializable {
public static final boolean CHECKSUM_ENABLED_DEFAULT = false;
+ public static final String CHUNK_ENCODING_ENABLED =
"s3.chunked-encoding.enabled";
+
+ public static final boolean CHUNK_ENCODING_ENABLED_DEFAULT = true;
Review Comment:
@nastra @manuzhang Thanks for thew review!
Yes, we should document this and I can make the change.
The reason to add `CHUNK_ENCODING_ENABLED`, is that I found this needs to be
disabled when using moto with s3, otherwise there will be encoded chunk
signatures appear in the file contents and causing parsing errors. I have not
yet file an issue.
If this can be fixed, then the property used in the tests will not be needed.
`S3FileIOProperties.CHUNK_ENCODING_ENABLED="false"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
