nastra commented on code in PR #12671:
URL: https://github.com/apache/iceberg/pull/12671#discussion_r2026378753
##########
build.gradle:
##########
@@ -529,7 +529,10 @@ project(':iceberg-aws') {
inputSpec.set(s3SignerSpec)
recommend.set(true)
}
- check.dependsOn('validateS3SignerSpec')
+ tasks.named('check') {
Review Comment:
I would prefer to not change this line and keep it as is. This is so that
we're in-line with how we define this in other places. And then right after the
`integrationTest` task (after L526) is defined you would add the
`check.dependsOn integrationTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
