xiaoxuandev commented on code in PR #12671:
URL: https://github.com/apache/iceberg/pull/12671#discussion_r2022177712


##########
aws/src/integration/java/org/apache/iceberg/aws/dynamodb/TestDynamoDbCatalog.java:
##########
@@ -56,8 +58,8 @@
 import software.amazon.awssdk.services.s3.model.HeadObjectRequest;
 import software.amazon.awssdk.services.s3.model.NoSuchKeyException;
 
-public class TestDynamoDbCatalog {

Review Comment:
   While mock services can simulate certain scenarios, they may not fully 
capture all edge cases or behaviors of real AWS services. I’d prefer to retain 
the original integration tests and introduce a separate group for mock tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to