lliangyu-lin commented on code in PR #12671:
URL: https://github.com/apache/iceberg/pull/12671#discussion_r2027343151
##########
aws/src/integration/java/org/apache/iceberg/aws/TestAssumeRoleAwsClientFactory.java:
##########
@@ -47,6 +48,16 @@
import software.amazon.awssdk.services.iam.model.PutRolePolicyRequest;
import software.amazon.awssdk.services.s3.model.S3Exception;
+@EnableAwsTest(
+ required = {
+ AwsIntegTestUtil.AWS_ACCESS_KEY_ID,
+ AwsIntegTestUtil.AWS_SECRET_ACCESS_KEY,
+ AwsIntegTestUtil.AWS_SESSION_TOKEN,
+ AwsIntegTestUtil.AWS_TEST_ACCOUNT_ID,
+ AwsIntegTestUtil.AWS_REGION,
+ AwsIntegTestUtil.AWS_TEST_BUCKET
+ })
+@ExtendWith(EnableAwsTestCondition.class)
Review Comment:
@nastra Thank you for the suggestion! I made a revision to change to
`EnabledIfEnvironmentVariables` and is working the same way, and it's good to
reuse as well. But some caveats I found are that
`EnabledIfEnvironmentVariables` cannot be applied on parent class and be
inherited to all children classes, which means we need to put these annotations
on each test class.
This might be enough, but some other thoughts I have are
* Extend the `EnabledIfEnvironmentVariables` to include `@inherited` (Need
to introduce a class)
* Use `AssumeNotNull` to check env vars in `BeforeAll` (Remove any
annotation, but is not clear to user why the tests are skipped since it's
embedded in test setup).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
