xiaoxuandev commented on code in PR #12671:
URL: https://github.com/apache/iceberg/pull/12671#discussion_r2027383951
##########
aws/src/integration/java/org/apache/iceberg/aws/TestAssumeRoleAwsClientFactory.java:
##########
@@ -47,6 +49,14 @@
import software.amazon.awssdk.services.iam.model.PutRolePolicyRequest;
import software.amazon.awssdk.services.s3.model.S3Exception;
+@EnabledIfEnvironmentVariables({
Review Comment:
I think skipping those tests is reasonable, but hardcoding AWS credentials
in environment variables poses security risks. While this is an existing issue,
it was never enabled for CI. I would prefer a configuration-based approach over
using @EnabledIfEnvironmentVariables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
