nastra commented on code in PR #12671:
URL: https://github.com/apache/iceberg/pull/12671#discussion_r2018602972
##########
aws/src/integration/java/org/apache/iceberg/aws/dynamodb/TestMockDynamoDbCatalog.java:
##########
@@ -56,8 +58,7 @@
import software.amazon.awssdk.services.s3.model.HeadObjectRequest;
import software.amazon.awssdk.services.s3.model.NoSuchKeyException;
-public class TestDynamoDbCatalog {
-
+public class TestMockDynamoDbCatalog extends BaseAwsMockTest {
Review Comment:
can we achieve the same without having to rename tests? I don't think it's
clear that tests need to have a `Mock` in the name to properly be executed and
it's very likely that this will be missed in the future if new tests are added.
Hence I would suggest to keep the test names as they are
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
