amogh-jahagirdar commented on code in PR #11131:
URL: https://github.com/apache/iceberg/pull/11131#discussion_r1800275372
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -370,14 +407,7 @@ private boolean canContainDeletedFiles(ManifestFile
manifest) {
canContainDroppedFiles = false;
}
- boolean canContainDropBySeq =
- manifest.content() == ManifestContent.DELETES
- && manifest.minSequenceNumber() < minSequenceNumber;
-
- return canContainExpressionDeletes
- || canContainDroppedPartitions
- || canContainDroppedFiles
- || canContainDropBySeq;
+ return canContainExpressionDeletes || canContainDroppedPartitions ||
canContainDroppedFiles;
Review Comment:
Moved the canContainDropBy seq check first because it's possible that a
manifest is not referenced but still needs to be rewritten in the case there
are aged out deletes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
