nastra commented on code in PR #11254:
URL: https://github.com/apache/iceberg/pull/11254#discussion_r1801607994
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -595,20 +596,22 @@ private List<ManifestFile> writeDataFileGroup(
}
protected List<ManifestFile> writeDeleteManifests(
- Collection<DeleteFileHolder> files, PartitionSpec spec) {
+ Collection<DeleteFile> files, PartitionSpec spec) {
return writeManifests(files, group -> writeDeleteFileGroup(group, spec));
}
private List<ManifestFile> writeDeleteFileGroup(
- Collection<DeleteFileHolder> files, PartitionSpec spec) {
+ Collection<DeleteFile> files, PartitionSpec spec) {
RollingManifestWriter<DeleteFile> writer =
newRollingDeleteManifestWriter(spec);
try (RollingManifestWriter<DeleteFile> closableWriter = writer) {
- for (DeleteFileHolder file : files) {
+ for (DeleteFile file : files) {
+ Preconditions.checkState(
Review Comment:
I'm fine either way. My reasoning for using `checkState` initially was that
something internally must have gotten wrong to reach that state state but I
guess it's also possible that some other internal code just passes delete files
that aren't a `PendingDeleteFile`.
Also getting this into a single line is hard, since the full line has 113
chars and I don't know what to omit from the error msg to make that fit into
100 chars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
