nastra commented on code in PR #11254:
URL: https://github.com/apache/iceberg/pull/11254#discussion_r1800720749
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -82,11 +82,9 @@ abstract class MergingSnapshotProducer<ThisT> extends
SnapshotProducer<ThisT> {
private final ManifestFilterManager<DeleteFile> deleteFilterManager;
// update data
- private final Map<PartitionSpec, List<DataFile>> newDataFilesBySpec =
Maps.newHashMap();
- private final DataFileSet newDataFiles = DataFileSet.create();
- private final DeleteFileSet newDeleteFiles = DeleteFileSet.create();
+ private final Map<PartitionSpec, DataFileSet> newDataFilesBySpec =
Maps.newHashMap();
Review Comment:
I can follow up on this in a separate PR and change it to `Map<Integer,
DataFileSet`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
