nastra commented on code in PR #11254:
URL: https://github.com/apache/iceberg/pull/11254#discussion_r1800550234
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -772,17 +773,139 @@ protected static class DeleteFileHolder {
*
* @param deleteFile delete file
*/
- DeleteFileHolder(DeleteFile deleteFile) {
+ PendingDeleteFile(DeleteFile deleteFile) {
this.deleteFile = deleteFile;
this.dataSequenceNumber = null;
}
- public DeleteFile deleteFile() {
- return deleteFile;
- }
-
+ @Override
public Long dataSequenceNumber() {
return dataSequenceNumber;
}
+
+ @Override
+ public Long fileSequenceNumber() {
+ return deleteFile.fileSequenceNumber();
+ }
+
+ @Override
+ public DeleteFile copy() {
Review Comment:
oops you're right. I think it's better to re-wrap them in all of these copy
methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
