nastra commented on code in PR #11254:
URL: https://github.com/apache/iceberg/pull/11254#discussion_r1800594126
##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -162,10 +160,10 @@ protected Expression rowFilter() {
protected List<DataFile> addedDataFiles() {
return ImmutableList.copyOf(
Review Comment:
we can also just collect directly using `ImmutableList.toImmutableList()` to
achieve the same thing so that we don't do the extra copy. I've updated that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
