nastra commented on code in PR #11254: URL: https://github.com/apache/iceberg/pull/11254#discussion_r1800578445
########## core/src/main/java/org/apache/iceberg/ManifestFilterManager.java: ########## @@ -68,9 +68,9 @@ public String partition() { private final Map<Integer, PartitionSpec> specsById; private final PartitionSet deleteFilePartitions; + private final Set<F> deleteFiles = newFileSet(); private final PartitionSet dropPartitions; private final CharSequenceSet deletePaths = CharSequenceSet.empty(); - private final Set<F> deleteFiles = newFileSet(); Review Comment: co-located this with `deleteFilePartitions` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org